Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover komponent #4088

Merged
merged 20 commits into from
Sep 17, 2024
Merged

Popover komponent #4088

merged 20 commits into from
Sep 17, 2024

Conversation

kristianulv23
Copy link
Contributor

@kristianulv23 kristianulv23 commented Sep 11, 2024 •
edited
Loading

Implementert en gjenbrukbar Popover-komponent

closes #3875

🎯 Sjekkliste

@fremtind-bot
Copy link
Collaborator

fremtind-bot commented Sep 11, 2024 •
edited
Loading

✅ Forhåndsvisning: https://jokul.fremtind.no/preview/feat/create-popover-component/
🔍 Commit: 7ce658e

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.

fremtind-bot added a commit that referenced this pull request Sep 11, 2024
@fremtind-bot
docs: preview #4088
a089db2
fremtind-bot added a commit that referenced this pull request Sep 11, 2024
@fremtind-bot
docs: preview #4088
a1510b6
fremtind-bot added a commit that referenced this pull request Sep 11, 2024
@fremtind-bot
docs: preview #4088
af38489
fremtind-bot added a commit that referenced this pull request Sep 11, 2024
@fremtind-bot
docs: preview #4088
b358d47
piofinn
piofinn reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@piofinn piofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser veldig bra ut! 🎉

La inn et par kommentarer om definisjon av typer (som vi snakket om tidligere), og vil også gjerne at vi fjerner eller bytter ut lodash siden det tar ganske stor plass.

packages/popover-react/src/Popover.tsx Outdated Show resolved Hide resolved
packages/popover-react/src/Popover.tsx Outdated Show resolved Hide resolved
packages/popover-react/src/Popover.tsx Outdated Show resolved Hide resolved
piofinn
piofinn requested changes Sep 12, 2024
View reviewed changes
packages/popover-react/src/Popover.tsx Outdated Show resolved Hide resolved
fremtind-bot added a commit that referenced this pull request Sep 12, 2024
@fremtind-bot
docs: preview #4088
bca0da2
fremtind-bot added a commit that referenced this pull request Sep 12, 2024
@fremtind-bot
docs: preview #4088
0078f64
fremtind-bot added a commit that referenced this pull request Sep 13, 2024
@fremtind-bot
docs: preview #4088
00d4dc5
fremtind-bot added a commit that referenced this pull request Sep 13, 2024
@fremtind-bot
docs: preview #4088
e5fb782
@kristianulv23 kristianulv23 marked this pull request as ready for review September 17, 2024 07:23
@kristianulv23 kristianulv23 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit d3b3075 Sep 17, 2024
5 checks passed
@kristianulv23 kristianulv23 deleted the feat/create-popover-component branch September 17, 2024 07:35
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@fremtind-bot
docs: remove preview #4088
89e3a78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piofinn piofinn piofinn approved these changes

@ivarni ivarni Awaiting requested review from ivarni

@zenabii zenabii Awaiting requested review from zenabii

Assignees

@kristianulv23 kristianulv23

Labels
None yet
Projects
Jøkul-teamet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ny komponent: Popover
4 participants
@kristianulv23 @fremtind-bot @ivarni @piofinn