Reduser bundle-størrelse for Framer Motion #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piofinn
force-pushed
the
feat/lighter-framer-motion
branch
from
187b386
to
fd7ca5c
Compare
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/feat/lighter-framer-motion/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Sep 23, 2024
fremtind-bot
added a commit
that referenced
this pull request
Sep 23, 2024
ivarni
previously approved these changes
Sep 24, 2024
|
Mistenker at testen som feiler kanskje må vente på async lasting av framer-motion eller noe lignende, uten at jeg har undersøkt. |
kristianulv23
previously approved these changes
Sep 24, 2024
Jepp, går også ut fra det! Rart at den ikke feilet før, men kan hende det er noen timing-forskjeller mellom Framer-versjonene. Skal putte det i en |
fremtind-bot
added a commit
that referenced
this pull request
Sep 24, 2024
piofinn
force-pushed
the
feat/lighter-framer-motion
branch
2 times, most recently
from
252d6d0
to
adcd2b6
Compare
fremtind-bot
added a commit
that referenced
this pull request
Sep 24, 2024
ivarni
previously approved these changes
Sep 25, 2024
piofinn
force-pushed
the
feat/lighter-framer-motion
branch
from
f0e77cc
to
4724e8e
Compare
fremtind-bot
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bruk lazy innlasting, og en modulær versjon av
motion-biblioteket fra Framer Motion for å redusere bundle-størrelse i komponentne som bruker dette. Tar utangspunkt i guiden på Framer sine sider.En rask test med et tomt Vite-prosjekt ga ca. 40 kB besparelse i ferdig bundle etter endringene (før gzip)!
Legger også til støtte for flere versjoner av Framer Motion, for å unngå konflikter dersom konsumenten allerede bruker Framer Motion andre steder. Har ikke testet alle versjoner, men har testet med både laveste og høyeste tillatte versjon og det fungerer fint. Det er ingen breaking changes i API-ene som brukes mellom disse versjonene.
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feil