fix: sørg for riktig spesifisitet i density-mixins #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/fix/density-mixins/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Nov 11, 2024
ivarni
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Jeg får litt lyst til å foreslå at når/hvis man ser på density på nytt så blir det en global switch for hele appen på rot-nivå (feks .jkl .jkl--compact eller .jkl) for sånn som det er nå genererer vi noen ganske massive CSS-selectors her.
Så kan heller "large/small" være kun på komponent-nivå uten at det arves nedover. Jeg tenker man ikke burde trenge å sette noen av delene for hele subtre av DOMen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fikser en bug der mixins for layout-density måtte angis i en spesifikk rekkefølge
closes #4277
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feil