Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repo #1961

Merged
merged 4 commits into from
May 3, 2024
Merged

Update Repo #1961

merged 4 commits into from
May 3, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented May 3, 2024

Goal

The goal of this PR is to update the GitHub org of the repository

Discussion

@wilwade wilwade requested a review from demisx as a code owner May 3, 2024 13:59
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides org name changes and linting, I see some removed logic related to the ci-base-image. Could you comment on the purpose of that in relation to the org move?

@wilwade
Copy link
Collaborator Author

wilwade commented May 3, 2024

Besides org name changes and linting, I see some removed logic related to the ci-base-image. Could you comment on the purpose of that in relation to the org move?

@JoeCap08055 It was noted in the PR where it went, but the reason why is:

  1. The container registry images didn't move over, so we had to publish the images before being able to run any PRs
  2. We had wanted to get out of the double PR requirement and disconnect the image publishing from the normal CI flow.

@wilwade wilwade enabled auto-merge (squash) May 3, 2024 14:40
@@ -74,53 +58,3 @@ jobs:
uses: ./.github/workflows/common/codecov
with:
code-cov-token: ${{ secrets.CODECOV_TOKEN }}

publish-ci-base-image:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this is moved into a separate branch: ci/ci-base-image

README.md Outdated Show resolved Hide resolved
Co-authored-by: Matthew Orris <[email protected]>
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through all changes (skimmed *.md changes)

🚢 it!

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline is green, so 🚢 it

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look legit

  • Just compiled locally so all good

@wilwade wilwade merged commit 7de94fb into main May 3, 2024
30 checks passed
@wilwade wilwade deleted the chore/repo-update branch May 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: move ci-base-image publishing out of merge.yml and into its own branch
4 participants