-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Repo #1961
Update Repo #1961
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides org name changes and linting, I see some removed logic related to the ci-base-image. Could you comment on the purpose of that in relation to the org move?
@JoeCap08055 It was noted in the PR where it went, but the reason why is:
|
@@ -74,53 +58,3 @@ jobs: | |||
uses: ./.github/workflows/common/codecov | |||
with: | |||
code-cov-token: ${{ secrets.CODECOV_TOKEN }} | |||
|
|||
publish-ci-base-image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this is moved into a separate branch: ci/ci-base-image
Co-authored-by: Matthew Orris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through all changes (skimmed *.md changes)
🚢 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline is green, so 🚢 it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look legit
- Just compiled locally so all good
Goal
The goal of this PR is to update the GitHub org of the repository
Discussion
LibertyDSNP
->frequency-chain
ci/ci-base-image
Closes chore: moveci-base-image
publishing out ofmerge.yml
and into its own branch #1910