706 run benchmarks and update weights for pallet collective once benchmarks are fixed for external pallets #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added constant CouncilMaxMembers for maximum number of council members. Increase max number of tech committee members from 3 to 10 to fix benchmarking.
Added pallet_collective to benchmarks now that it is working.
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
enddynayn
approved these changes
Jan 18, 2023
|
LGTM, I would double-check that those are still the config values we want. |
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 17 17
Lines 797 797
=======================================
Hits 671 671
Misses 126 126 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
rlaferla
deleted the
706-run-benchmarks-and-update-weights-for-pallet_collective-once-benchmarks-are-fixed-for-external-pallets
branch
rlaferla
restored the
706-run-benchmarks-and-update-weights-for-pallet_collective-once-benchmarks-are-fixed-for-external-pallets
branch
JoeCap08055
pushed a commit
that referenced
this pull request
Jan 19, 2023
…hmarks are fixed for external pallets (#923) The goal of this PR is to enable the benchmarks for the collective pallet. Closes #706 Co-authored-by: Jenkins <[email protected]>
JoeCap08055
pushed a commit
that referenced
this pull request
Jan 19, 2023
…hmarks are fixed for external pallets (#923) The goal of this PR is to enable the benchmarks for the collective pallet. Closes #706 Co-authored-by: Jenkins <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to enable the benchmarks for the collective pallet.
Closes #706