706 run benchmarks and update weights for pallet collective once benchmarks are fixed for external pallets #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added constant CouncilMaxMembers for maximum number of council members. Increase max number of tech committee members from 3 to 10 to fix benchmarking.
Added pallet_collective to benchmarks now that it is working.
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
wilwade
approved these changes
Jan 19, 2023
rlaferla
requested review from
shannonwells,
saraswatpuneet,
wilwade,
aramikm and
enddynayn
…tive-once-benchmarks-are-fixed-for-external-pallets' of https://github.com/LibertyDSNP/frequency into 706-run-benchmarks-and-update-weights-for-pallet_collective-once-benchmarks-are-fixed-for-external-pallets
Codecov Report
@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 84.47% 84.47%
=======================================
Files 17 17
Lines 805 805
=======================================
Hits 680 680
Misses 125 125 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
|
@wilwade said that I didn't have to run them again. But I could if you see a problem. |
…llet_collective-once-benchmarks-are-fixed-for-external-pallets
saraswatpuneet
approved these changes
Jan 23, 2023
rlaferla
deleted the
706-run-benchmarks-and-update-weights-for-pallet_collective-once-benchmarks-are-fixed-for-external-pallets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is enable benchmarks for the collective pallet
Closes #706