-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added benchmarking for pallet-collator-selection. #985
Added benchmarking for pallet-collator-selection. #985
Conversation
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 84.47% 84.47%
=======================================
Files 17 17
Lines 805 805
=======================================
Hits 680 680
Misses 125 125 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…llet_collator_selection-once-benchmarks-are-fixed-for-external-pallets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏋️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the weights generated that aren't for pallet-collator-selection. No need to churn those since they'll be generated before a release anyway.
…llet_collator_selection-once-benchmarks-are-fixed-for-external-pallets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One update and I think we need to remove the comment in runtime/frequency/src/lib.rs
// TODO: this uses default but we don't have weights yet. Issue: #608
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Clearing the way for this PR. We are always going to have a lot of churn on these files. Should be resolved with #813 and enabling ability to run just one benchmark
Goal
The goal of this PR is to add benchmarking for pallet-collator-selection.
Closes #608