Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmarking for pallet-collator-selection. #985

Conversation

rlaferla
Copy link
Contributor

Goal

The goal of this PR is to add benchmarking for pallet-collator-selection.

Closes #608

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #985 (5238946) into main (5930872) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files          17       17           
  Lines         805      805           
=======================================
  Hits          680      680           
  Misses        125      125           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…llet_collator_selection-once-benchmarks-are-fixed-for-external-pallets
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏋️

@JoeCap08055 JoeCap08055 self-requested a review January 27, 2023 19:39
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the weights generated that aren't for pallet-collator-selection. No need to churn those since they'll be generated before a release anyway.

…llet_collator_selection-once-benchmarks-are-fixed-for-external-pallets
@rlaferla rlaferla enabled auto-merge (squash) January 27, 2023 21:55
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One update and I think we need to remove the comment in runtime/frequency/src/lib.rs

// TODO: this uses default but we don't have weights yet. Issue: #608

Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more fix.

runtime/frequency/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wilwade wilwade dismissed shannonwells’s stale review January 30, 2023 14:13

Clearing the way for this PR. We are always going to have a lot of churn on these files. Should be resolved with #813 and enabling ability to run just one benchmark

@rlaferla rlaferla merged commit c621ba3 into main Jan 30, 2023
@rlaferla rlaferla deleted the 608-run-benchmarks-and-update-weights-for-pallet_collator_selection-once-benchmarks-are-fixed-for-external-pallets branch January 30, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run benchmarks and update weights for pallet_collator_selection once benchmarks are fixed for external pallets
5 participants