Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Token Address Linking #5

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Default Token Address Linking #5

merged 2 commits into from
Sep 24, 2024

Conversation

wilwade
Copy link
Contributor

@wilwade wilwade commented Sep 20, 2024 •
edited
Loading

Goal

The goal of this PR is:

Closes #3

Discussion

  • Question: Itemized or Paginated? Winner: Itemized
    • Itemized: Requires a bit more work to keep up to date
    • Paginated: Easy editing of multiple and removal of out of date items
  • Question: Indexed by coin_type or Array of Objects (Itemized Required)? Winner: Array of Objects
    • Indexed: Requires an array structure after it still to support multiple addresses with the same coin_type
    • Array: Has to be scanned fully each time, but likely a small dataset for most users

Checklist

  • PR Self-Review and Commenting
  • Docs updated
  • Tests added

How To Test the Changes

  1. Clone the pr branch
  2. npm run test
  3. Start Frequency Chain
  4. npm run deploy

@wilwade wilwade mentioned this pull request Sep 20, 2024
Closed
@wilwade
Default Token Address
6a16e38 
Updating various bits and using SLIP-0044 coin types

Add CI and tool-versions

Switch to itemized and add better tests and docs

Update Readme with better information

Switch to Payment Address

Fix test issues

Use just `frequency` as the namespace

Change name to default token address
wesbiggs
wesbiggs reviewed Sep 23, 2024
View reviewed changes
schemas/index.js Outdated Show resolved Hide resolved
wesbiggs
wesbiggs approved these changes Sep 24, 2024
View reviewed changes
Copy link

@wesbiggs wesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wilwade wilwade merged commit a89a125 into main Sep 24, 2024
1 check passed
@wilwade wilwade deleted the token-address-schema branch September 24, 2024 14:44
@wilwade wilwade mentioned this pull request Sep 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@wesbiggs wesbiggs wesbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connecting MSAs to Payment Addresses
3 participants
@wilwade @wesbiggs @JoeCap08055