Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Token Address Linking #1

Closed
wants to merge 9 commits into from
Closed

Conversation

wilwade
Copy link
Contributor

@wilwade wilwade commented Jun 14, 2024

Replaced by #5

@wilwade wilwade changed the title WIP Additional Wallet Addresses Jul 31, 2024
@wilwade wilwade marked this pull request as ready for review July 31, 2024 21:03
Copy link

@wesbiggs wesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I just left a couple of naming questions (that you may have thought about already). I am still working through how this repo relates to the (forthcoming) DSNP schemas repo, but this all makes sense for walletAddresses.

schemas/walletAddresses.js Outdated Show resolved Hide resolved
schemas/walletAddresses.js Outdated Show resolved Hide resolved
@JoeCap08055
Copy link

Recommend we reference an issue with this PR, that describes the problem being solved & other points, such as why we can't simply use 'addPublicKeyToMsa' (presumably because they're not supported key types, ie sr15519). Could also enhance the "Goal" in the README with the same information.

@wilwade
Copy link
Contributor Author

wilwade commented Aug 1, 2024

Recommend we reference an issue with this PR, that describes the problem being solved & other points, such as why we can't simply use 'addPublicKeyToMsa' (presumably because they're not supported key types, ie sr15519). Could also enhance the "Goal" in the README with the same information.

@JoeCap08055 Good points.

@wilwade wilwade changed the title Additional Wallet Addresses Payment Address Linking Aug 9, 2024
Copy link

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome!

Copy link

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JoeCap08055
Copy link

Not trying to be picky, but I wonder if there's a better term than "payment address" that would be more clear that these are NOT (necessarily) FRQCY-holding wallets for paying transaction fees, but are simply for informational purposes

@wilwade
Copy link
Contributor Author

wilwade commented Aug 13, 2024

Not trying to be picky, but I wonder if there's a better term than "payment address" that would be more clear that these are NOT (necessarily) FRQCY-holding wallets for paying transaction fees, but are simply for informational purposes

@JoeCap08055 I am 100% open to options. "Token Addresses" didn't feel right, but perhaps?

Some additional meh ideas:

  • Payment Target
  • Token Wallet
  • Transfer Address
  • Token Linked Address

@JoeCap08055
Copy link

@wilwade I'm similarly stumped as to a good name; here are some ChatGPT-generated options, maybe one will provide some inspiration:

  1. Payment Address Registry: Emphasizes that the addresses are for receiving payments across different tokens and blockchains.

  2. Cross-Chain Payment List: Highlights the chain-agnostic nature of the addresses.

  3. Token-Agnostic Address Book: Focuses on the token-agnostic aspect of the list.

  4. Receiver Address Pool: Suggests that the addresses are meant for receiving payments rather than sending.

  5. Payment Destination Directory: Conveys that the addresses are destinations for payments, independent of the blockchain.

  6. Universal Payment Address List: Emphasizes the universal applicability of the addresses.

  7. External Payment Address List: Indicates that these addresses are external to the Frequency blockchain in terms of payment capability.

  8. Token Receiver Address Book: Focuses on the role of these addresses as receivers of various tokens.

  9. Interchain Payment Address List: Highlights the interoperability across different blockchains.

  10. Wallet Destination Registry: Indicates that the addresses are associated with a wallet for receiving tokens.

@wilwade wilwade changed the title Payment Address Linking Default Token Address Linking Sep 20, 2024
@wilwade wilwade closed this Sep 20, 2024
@wilwade wilwade deleted the wallet-address-schema branch September 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants