HCaptcha, Favicon #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate HCaptcha IDE failed to add these * Fix tests for hcaptcha * Some renames to reflect the switch Update .env.example
shannonwells
force-pushed
the
feat/ui-updates
branch
from
a52a29a
to
ca54072
Compare
shannonwells
commented
Sep 23, 2024
| @@ -0,0 +1,18 @@ | |||
| import { Captcha } from "./Captcha"; | |||
There was a problem hiding this comment.
this was actually renamed.
shannonwells
commented
Sep 23, 2024
| { amount: "999999999", expected: "999999999000000000000" }, | ||
| { amount: "999999999.9", expected: "999999999900000000000" }, | ||
| { amount: "999999999999999.9", expected: "999999999999999900000000000" }, | ||
| { amount: "1", expected: "10000000000" }, |
There was a problem hiding this comment.
Substituted rococo here with paseo, which has 2 fewer decimals.
wilwade
reviewed
Sep 23, 2024
| @@ -31,7 +31,7 @@ jobs: | |||
| - run: yarn run test | |||
| - run: yarn run build | |||
| env: | |||
| PUBLIC_CAPTCHA_KEY: 6LesXHomAAAAAGVVTCgc467t8hvBbmK7IlYZCc8O | |||
| PUBLIC_CAPTCHA_KEY: 0f68a804-860e-4f9a-962a-39789afc8792 | |||
JoeCap08055
reviewed
Sep 24, 2024
There was a problem hiding this comment.
bug report: (running LOCAL, not testnet)
If you enter a wallet address, then answer the hCaptcha, the UI behaves as expected & the "Get some XRQCYs" button enables.
If you do it in reverse order (answer the hCaptcha, then enter an address), the button does not enable, and only a page reload gets you back to a useable state.
Co-authored-by: Aramik <[email protected]>
|
@JoeCap08055 Yeah I noticed that too, thanks for the nudge, I meant to make a bug report for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So now if in the root
.envfile, you setIt will use a locally running chain and the seed you provided (which defaults to
//Alice)for fauceting.
Closes #17
Closes #18
To Verify:
Please follow the updated Server and Client READMEs to launch server + client and test integration with either Paseo or local chain, bonus if both.