Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerDistributingActor should use min SoP (inclusion/exclusion bounds) #152

Closed
ela-kotulska-frequenz opened this issue Jan 4, 2023 · 2 comments · Fixed by #562
Closed

PowerDistributingActor should use min SoP (inclusion/exclusion bounds) #152

ela-kotulska-frequenz opened this issue Jan 4, 2023 · 2 comments · Fixed by #562
Assignees
@shsms
Labels
part:power-management Affects the management of battery power and distribution priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users
Milestone
v0.24.0

Comments

@ela-kotulska-frequenz
Copy link
Contributor

What's needed?

Microgrid will expose min bounds for charge/discharge power soon.
After that we should update PowerDistributing algorithm to look at it.

Proposed solution

Implementation should be in old MOS repository, because in past we had this min bounds.
To be checked

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@ela-kotulska-frequenz ela-kotulska-frequenz added priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users part:power-management Affects the management of battery power and distribution labels Jan 4, 2023
@ela-kotulska-frequenz ela-kotulska-frequenz added this to the v0.17.0 milestone Jan 4, 2023
@ela-kotulska-frequenz ela-kotulska-frequenz self-assigned this Jan 4, 2023
@ela-kotulska-frequenz ela-kotulska-frequenz added the status:blocked Other issues must be resolved before this can be worked on label Jan 13, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added status:blocked Other issues must be resolved before this can be worked on and removed status:blocked Other issues must be resolved before this can be worked on labels Apr 21, 2023
@leandro-lucarella-frequenz
Copy link
Contributor

Blocking because we need a new version of the microgrid API service to be released for being able to merge this.

@llucax llucax changed the title PowerDistributingActor should use min SoP PowerDistributingActor should use min SoP (inclusion/exclusion bounds) Jun 27, 2023
@llucax llucax modified the milestones: v0.22.0, v0.23.0 Jun 27, 2023
@thomas-nicolai-frequenz
Copy link

thomas-nicolai-frequenz commented Jul 26, 2023 •
edited
Loading

@shsms the min and max SoP bounds should be first exposed via the BatteryPool. Second step would also be to look at the bounds if someones sends a power request thats out of bounds.

@llucax llucax removed the status:blocked Other issues must be resolved before this can be worked on label Aug 1, 2023
@llucax llucax modified the milestones: v0.23.0, v0.24.0, v0.25.0 Aug 1, 2023
@llucax llucax linked a pull request Aug 2, 2023 that will close this issue
Stream exclusion bounds from the battery pool #537
Merged
@llucax llucax removed a link to a pull request Aug 2, 2023
Stream exclusion bounds from the battery pool #537
Merged
@shsms shsms mentioned this issue Aug 3, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2023
@llucax
Support exclusion bounds in power distributor (#562)
6258c76 
To be merged after #537

Closes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shsms shsms

Labels
part:power-management Affects the management of battery power and distribution priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users
Projects
Python SDK Roadmap
Status: Done
Milestone
v0.24.0
Development

Successfully merging a pull request may close this issue.

Support exclusion bounds in power distributor shsms/frequenz-sdk-python
7 participants
@llucax @shsms @thomas-nicolai-frequenz @sahas-subramanian-frequenz @ela-kotulska-frequenz @stefan-brus-frequenz @leandro-lucarella-frequenz