Skip to content

Commit

Permalink
(LowPass) Change enable value, update docs. (lavalink-devs#673)
Browse files Browse the repository at this point in the history
* LowPass: enforce minimum, change enable value, update docs.

* Remove coercing to allow the filter to actually be disabled.

* Bump lowpass minimum to 1.0f

* Enforce >1.0
  • Loading branch information
devoxin authored Jun 23, 2022
1 parent 53345db commit 55a9968
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion IMPLEMENTATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,9 @@ Note that filters may take a moment to apply.
}

// Higher frequencies get suppressed, while lower frequencies pass through this filter, thus the name low pass.
// Any smoothing values equal to, or less than 1.0 will disable the filter.
"lowPass": {
"smoothing": 20.0
"smoothing": 20.0 // 1.0 < x
}
}
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class LowPassConfig(
.setSmoothing(smoothing)
}

override val isEnabled: Boolean get() = smoothing != 20.0f
override val isEnabled: Boolean get() = smoothing > 1.0f
}

abstract class FilterConfig {
Expand Down

0 comments on commit 55a9968

Please sign in to comment.