Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed BinaryClassificationTrainer #227

Merged
merged 3 commits into from
Jul 16, 2022
Merged

fix: Fixed BinaryClassificationTrainer #227

merged 3 commits into from
Jul 16, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 16, 2022

This PR introduces the following modifications:

  • fixes trainer for binary classification when the target is wrongly shaped or doesn't have the good data type
  • fixes the evaluation loop of binary classification trainer
  • extends unittests

@frgfm frgfm added type: bug Something isn't working ext: tests Related to test module: trainer labels Jul 16, 2022
@frgfm frgfm added this to the 0.2.1 milestone Jul 16, 2022
@frgfm frgfm self-assigned this Jul 16, 2022
@frgfm frgfm mentioned this pull request Jul 16, 2022
3 tasks
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #227 (1130104) into main (49125c2) will decrease coverage by 0.08%.
The diff coverage is 78.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   93.51%   93.43%   -0.09%     
==========================================
  Files          56       56              
  Lines        3132     3136       +4     
==========================================
+ Hits         2929     2930       +1     
- Misses        203      206       +3     
Impacted Files Coverage Δ
holocron/trainer/classification.py 86.44% <63.15%> (-4.64%) ⬇️
holocron/trainer/core.py 89.57% <100.00%> (+0.30%) ⬆️
holocron/trainer/segmentation.py 100.00% <100.00%> (ø)

@frgfm frgfm added the critical label Jul 16, 2022
@frgfm frgfm merged commit 9871899 into main Jul 16, 2022
@frgfm frgfm deleted the trainer-fix branch July 16, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical ext: tests Related to test module: trainer type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant