-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRAN connection issues #116
Conversation
Changes in check package
Work on #113 for vignette
About bumping version, I didn't. I let you choose about it. Feel free to commit, of course. |
It's already present at the begin of the test
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 420 420
=========================================
Hits 420 420 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I tested all the tests without an internet connection and removed the testthat::skip_if_offline() where the test still passed without it
@peterdesmet: I see you removed some "skips". Are you sure? You need internet connection for reading |
700a351
to
efb3468
Compare
Yes, I tested all. |
I kept CRAN in relatedLink and provider in codemeta.json
33789b4
to
0ca101b
Compare
This PR aims to solve #113, #114 and #115.
I used
testthat::skip_if_offline()
where needed in each of the test files. I preferred this skip function overtestthat::skip_on_cran()
. In this way a developer is free to test the package even if internet is (temporarily) unavailable.About the vignette: I transformed some R chunks to markdown code where strictly needed. I know, this is not really elegant but I don't see really any other valid solution. Using package
mockery
and its functionstub()
will be way far less elegant than the solution proposed here.