Update react/socket to v0.8.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2017 11:53
avoid warnings by removing unsed argument $stream
Remove not needed and not possible anymore React\MySQL\Connector Connector: Use connect($uri) instead of create($host, $port) and pass resolver option properly
|
The suggest change still leaves the hard-coded version dependency. Why not change to an open range? In the future react/socket will release version 0.9, at which point this library will again break. |
clue
approved these changes
May 31, 2017
| "react/socket": "0.4.*", | ||
| "react/dns": "0.4.*", | ||
| "react/socket-client": "0.4.*" | ||
| "react/socket": "0.8.*", |
There was a problem hiding this comment.
As per reactphp/socket#75, you may as well target future versions with ^1.0 || ^0.8 here 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.