-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you have any plans to support vue3? #137
Comments
@nsano-rururu yes, I did, any work or help is appreciated! |
Hi, some news about vue 3 compatibility ?? |
@fritx Is there a version that supports VUE3 or is it under development? |
@XIwen-chuan It seems that vue3 support hasn't done anything yet.
|
@nsano-rururu thank you. this project is unique and useful. looking forward to supporting vue3 |
@nsano-rururu @XIwen-chuan now I'm trying with this guide: Vue 3 Migration Build: safely upgrade your app to Vue 3 (Pt. 1) |
This comment was marked as off-topic.
This comment was marked as off-topic.
@nsano-rururu yes, agreed, but eslint is now off-topic right now. I've just pushed the wip branch above ...where I've worked out several errors except this one (failing to insert styled tag into editor):
Official guide I was following: |
It's not irrelevant as eslint will tell you where you need vue3 compatibility with warnings and errors. I would appreciate it if you could consider it as information that there is such a thing. There is no compulsion to adopt or not. |
…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here
…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335
eslint is done! And now it seems to work. Checkout it out, pls wip-vue3 Any interest in contributing to PR that switches to vite ? @nsano-rururu @XIwen-chuan @PaulSaveur |
…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here
…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335
Yes,my pleasure |
…r eslint warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335
Here are some updates on vue3 support: Switching to vue-demi
Switching to vite -- branch: vite
Release
Some other related work by community |
@fritx @XIwen-chuan I've tried it locally so far. I don't know how to fix existing vue-cli commands to vite commands. .eslintrc.js add eqeqeq: 'off',
'no-tabs': 'off', index.html add 「<script type="module" src="/src/main.js"></script>」 <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<title>vue-at</title>
</head>
<body>
<div id="app"></div>
<script src="dist/demo.js"></script>
<script type="module" src="/src/main.js"></script>
</body>
</html> [new]vite.config.js import { defineConfig } from 'vite'
import path from 'path'
import envCompatible from 'vite-plugin-env-compatible'
import { createHtmlPlugin } from 'vite-plugin-html'
import { viteCommonjs } from '@originjs/vite-plugin-commonjs'
import vue from '@vitejs/plugin-vue'
// https://vitejs.dev/config/
export default defineConfig({
resolve: {
alias: [
{
find: /^~/,
replacement: ''
},
{
find: '@',
replacement: path.resolve(__dirname, 'src')
}
],
extensions: [
'.mjs',
'.js',
'.ts',
'.jsx',
'.tsx',
'.json',
'.vue'
]
},
plugins: [
vue(),
viteCommonjs(),
envCompatible(),
createHtmlPlugin({
inject: {
data: {
title: 'vue-at'
}
}
})
],
css: {
preprocessorOptions: {
sass: {},
scss: {}
}
},
build: {}
}) package.json add "prepublish": "npm run build", "@vitejs/plugin-vue": "^3.0.1", {
"name": "vue-at",
"description": "At.js for Vue",
"version": "3.0.0-alpha.0",
"author": "Fritz Lin <[email protected]>",
"repository": "https://github.com/fritx/vue-at",
"scripts": {
"lint:fix": "vue-cli-service lint",
"lint": "vue-cli-service lint --no-fix",
"dev:dist": "vue-cli-service serve --skip-plugins eslint",
"dev": "vue-cli-service serve",
"build:at": "vue-cli-service build ./src/At.vue --target lib --name vue-at",
"build:at-ta": "vue-cli-service build ./src/AtTextarea.vue --target lib --name vue-at-textarea",
"build": "rimraf dist && run-p build:at build:at-ta && rimraf dist/demo.html",
"prepublish": "npm run build",
"serve-vite": "vite",
"build-vite": "vite build",
"preview-vite": "vite preview"
},
"main": "dist/vue-at.common.js",
"engines": {
"node": ">= 14.x"
},
"dependencies": {
"@vitejs/plugin-vue": "^3.0.1",
"textarea-caret": "^3.1.0"
},
"peerDependencies": {
"vue": "3.x"
},
"devDependencies": {
"@babel/core": "^7.18.9",
"@originjs/vite-plugin-commonjs": "^1.0.1",
"@vue/cli-plugin-eslint": "^5.0.8",
"@vue/cli-service": "^5.0.8",
"@vue/compat": "^3.1.0",
"@vue/compiler-sfc": "^3.1.0",
"@vue/eslint-config-standard": "^8.0.1",
"element-plus": "^2.2.12",
"eslint": "^8.21.0",
"eslint-plugin-vue": "^9.3.0",
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2",
"sass": "^1.53.0",
"sass-loader": "^13.0.2",
"vite": "^3.0.1",
"vite-plugin-env-compatible": "^1.1.1",
"vite-plugin-html": "3.2.0",
"vue": "^3.1.0",
"vue-loader": "^16.0.0",
"webpack": "^5.73.0"
}
} |
@nsano-rururu cool, I'll take a look later Also see #137 (comment) |
There is no problem other than eslint errors. [CORP\sano@a-19f9vs8e9ite4 vue-at]$ npm run lint
> [email protected] lint
> eslint --ext .js,.vue --ignore-path .gitignore src
/home/sano/dkwork3/e/vue-at/src/util.js
8:22 error Expected '===' and instead saw '==' eqeqeq
14:27 error Unexpected tab character no-tabs
15:21 error Unexpected tab character no-tabs
19:20 error Expected '===' and instead saw '==' eqeqeq
25:26 error Expected '!==' and instead saw '!=' eqeqeq
✖ 5 problems (5 errors, 0 warnings) |
@nsano-rururu ah that's fixed. and 3.0.0-alpha.0 was already released. npm i -S [email protected]
# or
npm i -S vue-at@next demo: https://github.com/we-demo/vue-at-vite-app progress: #137 (comment) |
@nsano-rururu i'm not sure how to still support babel es2015-safe build via vite, any idea? |
Sounds like you need to look into babel-preset-env options. |
babel-preset-env seems to transpile everything to ES5 notation if no options are specified. |
@nsano-rururu but i could not manage to make babel work well with vite (library mode) 😢 |
@fritx |
@fritx |
@junaidshad try |
@junaidshad also try the umd way, it can be a fallback solution |
@fritx |
No description provided.
The text was updated successfully, but these errors were encountered: