This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Fix extracting dates from certificates using UTCTime #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomstarstuck Can you look with "master"? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to ejabberd with .pam certificates, I was getting error that certificate is expired.
I have debugged the issue and it turned out, that notBefore and notAfter components of certificate are encoded as UTCTime in my certificate. That data format have only 2 digits of year, versus 4 digits in GeneralizedTime. That difference was causing datetime.strptime to wrongly interpret year.
My change is avoiding conversion to/from string in favour of using built in pyasn1 methods for conversion to datetime. That solution should work independent on time format used in cerificate.