Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slate to 0.44 #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update slate to 0.44 #1

wants to merge 5 commits into from

Conversation

cdunn
Copy link

@cdunn cdunn commented Nov 13, 2018

Needs a little more work but tests pass and appear working against slate 0.44. Putting for reference for others who are also in slate plugin hell :)

@cdunn cdunn changed the title Update slate to 0.44 [wip] Update slate to 0.44 Nov 13, 2018
@cdunn cdunn changed the title [wip] Update slate to 0.44 Update slate to 0.44 Nov 16, 2018
@PeterKottas
Copy link

Look quite good already! I am looking forward to this being merged as this plugin is currently causing thousands of warnings in my app :)

@PeterKottas
Copy link

Is there any progress on this? The situation around this plugin is rly starting to be quite confusing :D

@bryanph
Copy link

bryanph commented Jan 6, 2019

Thanks for sharing your work with all of us! What still needs to happen in this pr?

@PeterKottas
Copy link

Check this out https://github.com/guestbell/slate-plugins . While I appreciated the work being done here, I grew inpatient and did it myself. You can get the fully functional plugin on that link.

@cdunn
Copy link
Author

cdunn commented Jan 9, 2019

@bryanph tests are passing and I haven't had any issues in dev thusfar. maybe @quentez can take a look?

@achimkoellner
Copy link

Any reason why this is not merged to make a new release?

@omar-sr88
Copy link

Bumping here to ask again

Any reason why this is not merged to make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants