Update FS-1092-anonymous-type-tagged-unions.md #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Jun 8, 2021
dsyme
reviewed
Jun 8, 2021
| @@ -88,6 +88,8 @@ An anonymous type-tagged union type should only be considered for when a union i | |||
|
|
|||
| 5. There is some identified, concrete, simply explained benefit over using labelled discriminated unions, e.g. "we have a simpler API with fewer overloads". | |||
|
|
|||
| 6. There is no possibility that the type will end up being consumed by .Net languages other than F#. | |||
There was a problem hiding this comment.
This is a bit strong - it might be reasonable to expose - but I know what you mean :)
There was a problem hiding this comment.
Similar thoughts, but it's a good thing to clarify for now. Maybe as the feature takes shape a bit more we'll have a more nuanced position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention the need to avoid exposing usage of this feature to non-F# .Net languages.