Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Move distance metrics from the ML module to Linear Algebra #200

Closed
Recktenwald opened this issue Apr 29, 2022 · 4 comments

Comments

@Recktenwald
Copy link

Is your feature request related to a problem? Please describe.
Since F# enforces strict linearity, the distance metrics are only usable in the ML module and the ones after it in the .fsproj file. In particular, they are not usable in the optimization module, I am currently working on.

Describe the solution you'd like
Put the distance in the linear algebra module. For code that already uses the distance metrics, this would break backward compatibility. I.e. someone calling ML.DistanceMetrics.euclidean would find their code no longer working

@muehlhaus
Copy link
Member

I think we should move "DistanceMetrics" into the Core module. This makes it usable everywhere and would be a better place anyway. We can reference it in the ML module and deprecate it there... This should fix the problems

@bvenn
Copy link
Member

bvenn commented May 2, 2022

I would also prefer moving DistanceMetrics into core, right beneath Correlation. @Recktenwald, shall I make the changes or do you want to do it along with the optimization PR?

@Recktenwald
Copy link
Author

You can go ahead and just make the change right now, I think it will take some time until I will do the PR.

bvenn added a commit that referenced this issue May 2, 2022
@bvenn
Copy link
Member

bvenn commented May 2, 2022

closed by 4f4e08b

@bvenn bvenn closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants