Avoid panic when using a released CFRunLoop #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As fsevents is saving the result of `CFRunLoopGetCurrent` and stopping it from a separate thread, it's necessary to increase the reference count of the returned CFRunLoopRef. In the event that the run loop is terminated by other means, `stop` might be working with a deallocated reference and produce a panic (SIGSEGV).
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 71.18% 71.37% +0.19%
==========================================
Files 3 3
Lines 288 290 +2
==========================================
+ Hits 205 207 +2
Misses 61 61
Partials 22 22
Continue to review full report at Codecov.
|
patsoffice
approved these changes
Jul 18, 2018
|
@adriansr Thanks for the patch. @patsoffice Thanks for reviewing. Will merge this after #41 is merged (which fixes failing tests in Go 1.10.4 and Go 1.11). |
|
@adriansr @andrewkroh Yes, apologies for the delay. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fsevents is saving the result of
CFRunLoopGetCurrentand stoppingit from a separate thread, it's necessary to increase the reference
count of the returned CFRunLoopRef.
In the event that the run loop is terminated by other means,
stopmight be working with a deallocated reference and produce a panic
(SIGSEGV).
What does this pull request do?
Fixes an occassional panic
Where should the reviewer start?
How should this be manually tested?