Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No time library for freeBSD? #1739

Closed
trevorwhitney opened this issue Sep 9, 2024 · 3 comments · Fixed by #1752
Closed

No time library for freeBSD? #1739

trevorwhitney opened this issue Sep 9, 2024 · 3 comments · Fixed by #1752

Comments

@trevorwhitney
Copy link

We just recently tried to update from v1.7.0 to v1.47.7(I know, huge jump), and it looks like in that jump the time functions were split out to OS specific version (linux, mac, and windows). Unfortunately, this breaks our freebsd/amd64 build complaining of:

vendor/github.com/fsouza/fake-gcs-server/internal/backend/fs.go:120:82: undefined: createTimeFromFileInfo
vendor/github.com/fsouza/fake-gcs-server/internal/backend/fs.go:156:82: undefined: createTimeFromFileInfo

Is this a known issue? Should it/can it use the linux version? Is support for freeBSD intentionally being dropped? Please let me know if I can help so we can upgrade our very out of date version. Thanks!

@fsouza
Copy link
Owner

fsouza commented Sep 22, 2024

I assume this was by accident.

We can fix it and add a CI job that cross-compiles to freebsd. I don't have access to infrastructure to run tests on freebsd, but we can guarantee that compilation won't break again in the future at least.

@fsouza
Copy link
Owner

fsouza commented Sep 22, 2024

This is fixed and the fix was included in 1.50.0. Let me know if you still have any issues!

jonmseaman pushed a commit to jonmseaman/fake-gcs-server that referenced this issue Sep 22, 2024
@trevorwhitney
Copy link
Author

thank you, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants