Fixed patchObject ignoring ContentType and ContentEncoding #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnAfraid
force-pushed
the
bugfix/patch-content-type
branch
from
4633abc
to
be30dba
Compare
fsouza
reviewed
Dec 16, 2023
internal/grpc/server.go
Outdated
| @@ -44,7 +44,7 @@ func (g *Server) GetBucket(ctx context.Context, req *pb.GetBucketRequest) (*pb.B | |||
| TimeCreated: timestamppb.New(bucket.TimeCreated), | |||
| } | |||
| return grpc_bucket, nil | |||
| ///return GetBucketFromBackend(g.backend, req.Bucket) | |||
| // /return GetBucketFromBackend(g.backend, req.Bucket) | |||
There was a problem hiding this comment.
I realize that this was autoformating, but do you want to take the opportunity to delete this line altogether 😁
UnAfraid
force-pushed
the
bugfix/patch-content-type
branch
from
be30dba
to
6877db5
Compare
|
Thanks for merging it, do you have an idea of when it will be released? |
|
I just pushed a new tag. The release should be available soon! |
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to update object's ContentType and noticed that only metadata was updated, but not the ContentType upon looking at the code i noticed that its ignored entirely.
Most likely fixes #273