-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed patchObject ignoring ContentType and ContentEncoding #1430
Conversation
4633abc
to
be30dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
internal/grpc/server.go
Outdated
@@ -44,7 +44,7 @@ func (g *Server) GetBucket(ctx context.Context, req *pb.GetBucketRequest) (*pb.B | |||
TimeCreated: timestamppb.New(bucket.TimeCreated), | |||
} | |||
return grpc_bucket, nil | |||
///return GetBucketFromBackend(g.backend, req.Bucket) | |||
// /return GetBucketFromBackend(g.backend, req.Bucket) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that this was autoformating, but do you want to take the opportunity to delete this line altogether 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing!
be30dba
to
6877db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Thanks for merging it, do you have an idea of when it will be released? |
I just pushed a new tag. The release should be available soon! |
Thank you again! |
I was trying to update object's ContentType and noticed that only metadata was updated, but not the ContentType upon looking at the code i noticed that its ignored entirely.
Most likely fixes #273