Support the projection parameter in getObject
#1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
fsouza
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Thank you very much for contributing! This looks good overall.
This behavior is not testeable using the Go GCS client, because it hardcodes the value full when performing the HTTP request (see implementation).
Do you think it'd make sense to write a test that sends a low-level request that bypasses the client?
There are some examples in object_test.go, such as TestServerClientObjectUpdateContentType.
I guess we'd want to test the default behavior and explicitly setting the projection to noAcl?
fsouza
approved these changes
Mar 18, 2024
According to the behavior described in the [official documentation][1]. That is, ACL information should only be returned if `projection=full` is provided as GET parameter. This behavior is not testeable using the Go GCS client, because it hardcodes the value `full` when performing the HTTP request (see [implementation][2]). [1]: https://cloud.google.com/storage/docs/json_api/v1/objects/get#parameters [2]: https://github.com/googleapis/google-cloud-go/blob/storage/v1.39.0/storage/http_client.go#L413
manuteleco
force-pushed
the
support_projection_in_getobject
branch
from
98693d7
to
bb21b0a
Compare
fsouza
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the behavior described in the official documentation. That is, ACL information should only be returned if
projection=fullis provided as GET parameter.This behavior is not testeable using the Go GCS client, because it hardcodes the value
fullwhen performing the HTTP request (see implementation).