Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle batch calls #677

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Handle batch calls #677

merged 5 commits into from
Feb 21, 2022

Conversation

m4gus88
Copy link
Contributor

@m4gus88 m4gus88 commented Feb 7, 2022

Addressing issue #411, added a handler for batch calls.

@fsouza
Copy link
Owner

fsouza commented Feb 12, 2022

Hi @m4gus88, thanks for contributing! Can you add some tests?

@m4gus88
Copy link
Contributor Author

m4gus88 commented Feb 12, 2022

@fsouza I don't 'really know anything about Go testing, but I'll give it a try

Add a rudamental test for batch delete
@m4gus88
Copy link
Contributor Author

m4gus88 commented Feb 21, 2022

@fsouza Any chance this will be merged and released any time soon?

@fsouza
Copy link
Owner

fsouza commented Feb 21, 2022

@fsouza Any chance this will be merged and released any time soon?

Hey, somehow I missed this after the last approval for running, I'm really sorry about that. I'll review it today and if everything looks good I'll merge it and release it!

Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor points, but I'll merge it once they're addressed!

fakestorage/server.go Outdated Show resolved Hide resolved
fakestorage/server_test.go Outdated Show resolved Hide resolved
fakestorage/server.go Outdated Show resolved Hide resolved
fakestorage/server_test.go Outdated Show resolved Hide resolved
@fsouza fsouza enabled auto-merge (squash) February 21, 2022 18:10
@fsouza
Copy link
Owner

fsouza commented Feb 21, 2022

Thank you!

@fsouza fsouza merged commit dee5921 into fsouza:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants