Content-Range is incorrectly specified. #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. Would you be able to add a test that fails with the previous code and passes with the fix. Ideally something using the SDK rather than asserting on the value of the headers. |
|
@fsouza thx comment. I don't know how to use the SDK, but I wrote some unit tests. Please feel free to make any changes. |
fsouza
approved these changes
May 10, 2022
| @@ -686,7 +687,7 @@ func (s *Server) handleRange(obj Object, r *http.Request) (ranged bool, start in | |||
| if end > int64(len(obj.Content)) { | |||
| end = int64(len(obj.Content)) | |||
| } | |||
| return true, start, end, obj.Content[start:end] | |||
| return true, start, end - 1, obj.Content[start:end] | |||
There was a problem hiding this comment.
Shouldn't this be:
return true, start, end - 1, obj.Content[start:end-1]
?
There was a problem hiding this comment.
Nope, in the slice expression the upper bound is non-inclusive: https://go.dev/ref/spec#Slice_expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, a file of 22709217 bytes content is
should be
0-22709216/22709217instead of0-22709217/22709217.Chrome will not handle this correctly and videos and other files will not play.
RFC:
https://httpwg.org/specs/rfc7233.html#header.content-range