Return a 409 when attempting to create a bucket that already exists #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates createBucketByPost to return a 409 response when the bucket being created already exists. This matches the behavior of the GCS API. Fixes fsouza#804.
fsouza
approved these changes
Jun 2, 2022
| @@ -70,6 +71,18 @@ func (s *Server) createBucketByPost(r *http.Request) jsonResponse { | |||
| return jsonResponse{errorMessage: err.Error(), status: http.StatusBadRequest} | |||
| } | |||
|
|
|||
| _, err := s.backend.GetBucket(name) | |||
There was a problem hiding this comment.
I was wondering if we should have the backend return an error or something like that (to avoid TOCTOU). This is an emulator though, I imagine TOCTOU isn't really an issue, and if it becomes an issue we can fix it x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates createBucketByPost to return a 409 response when the
bucket being created already exists. This matches the behavior of the
GCS API.
Fixes #804.