#1254 Support VB.NET's case-insensitive assembly attributes #1255
+35
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let private regexAttrOptionsCpp = Option.None | ||
| // VB.NET is case-insensitive | ||
| let private regexAttrOptionsVb = Option.Some (RegexOptions.IgnoreCase) | ||
|
|
There was a problem hiding this comment.
I don't think we need these.
|
I fixed the issues you pointed out and updated the commit accordingly. |
|
👍 Maybe you should also extend the specs here? |
|
Digging into the code a bit more, I discovered the Edit: What's the policy on squashing? Should I squash my commits when I'm done fixing? |
…and UpdateAttributes
|
The new commit addresses both issues in |
|
Awesome. thanks for taking care of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case insensitive regex matching when looking for assembly attributes in
.vbassembly info files.Fixes issue #1254.