improve default npm path handling #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make more sense to try to use what's on the environments path first? Then maybe default to these? |
|
Yes, that is really the better way to do it. Gimme a sec |
|
It now attempts to extract the path via |
krgn
force-pushed
the
improve-default-npm-path-handling
branch
from
7376234
to
309a262
Compare
krgn
force-pushed
the
improve-default-npm-path-handling
branch
from
309a262
to
f2ccb3a
Compare
|
cool thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test to check whether
npmexists in/usr/binas a standard location in addition to the existing default/usr/local/bin. Also, I changed the shebang ofbuild.shsuch that it uses/usr/bin/env bashinstead of hard-coding the path to bash (which does not work on systems like NixOS).