NuGet: support fallback framework groups

[cdrnet]

Since NuGet 2.0, dependencies and references can be specified by target
framework, where only the entries from the matching group are considered.
NuGet also allows defining a fallback group where the targetFramework is
missing, which is used if none of the other groups match.

Previously FAKE did emit the empty targetFramework attribute, which causes
NuGet to complain. This change skips the attribute if its value is null
or empty, in compliance with the nuget specs.

[forki]

Is it backwards compatible?
On Aug 4, 2014 4:17 PM, "Christoph Ruegg" [email protected] wrote:

Since NuGet 2.0, dependencies and references can be specified by target
framework, where only the entries from the matching group are considered.
NuGet also allows defining a fallback group where the targetFramework is
missing, which is used if none of the other groups match.

Previously FAKE did emit the empty targetFramework attribute, which causes
NuGet to complain. This change skipts the attribute if its value is null

or empty, in compliance with the nuget specs.

You can merge this Pull Request by running

git pull https://github.com/cdrnet/FAKE nuget-fallbackFrameworkGroup

Or view, comment on, or merge it at:

#514
Commit Summary

• NuGet: support fallback framework groups

File Changes

• M src/app/FakeLib/NuGet/NugetHelper.fs
  https://github.com/fsharp/FAKE/pull/514/files#diff-0 (14)

Patch Links:

• https://github.com/fsharp/FAKE/pull/514.patch
• https://github.com/fsharp/FAKE/pull/514.diff

—
Reply to this email directly or view it on GitHub
#514.

[cdrnet]

It only affects a case which previously caused an error when calling into nuget.exe:

Framework name is missing.
Parametername: frameworkName
Running build failed.

So yes - unless someone was relying on that error (very unlikely)

[forki]

👍

[cdrnet]

Thanks!