Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to PackageLicenseExpression #72

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bartelink
Copy link
Member

Use PackageLicenseExpression to more formally/idiomatically declare MIT License per NuGet's recommendations.

See demystifyfp/FsToolkit.ErrorHandling#236 for tradeoffs and/or prior art

@@ -1,21 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFramework>netstandard2.0</TargetFramework>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in some strange cases, you need to explicitly specify the framework if you have a single-item list...

@bartelink
Copy link
Member Author

Does not have to be done now and/or merged into this release or branch

@samritchie samritchie merged commit 7907354 into fsprojects:multi-key-attributes Nov 29, 2023
4 checks passed
@bartelink bartelink deleted the license-expr branch November 29, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants