Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Net Core #320

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Add documentation for Net Core #320

merged 2 commits into from
Jun 11, 2019

Conversation

samhanes
Copy link
Contributor

No description provided.

@samhanes
Copy link
Contributor Author

I may have broken this with my last PR - I'm getting this error on the GenerateDocs build step:

Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'FSharp.Compiler.Private, Version=4.4.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
   at Sample.Microsoft.FSharp.Compiler.Interactive.Main.MainMain(String[] argv)

Does that make sense to anyone?

@smoothdeveloper
Copy link
Collaborator

@samhanes are you using VS 2017? sounds like a case of updating, rebooting and trying again.

smoothdeveloper
smoothdeveloper reviewed Nov 23, 2018
View reviewed changes
docs/content/unit-testing.fsx Outdated
@@ -87,7 +87,7 @@ module MyTests =

//unit test
let ``best sales rep in Canada``() =
let expected = Some( GetSalesChampion.Record("Jos�", "Saraiva"))
let expected = Some( GetSalesChampion.Record("Jos�", "Saraiva"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is some kind of encoding glitch here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - replaced with a unicode é.

@samhanes samhanes mentioned this pull request Nov 24, 2018
Open
@samhanes
Copy link
Contributor Author

@smoothdeveloper I am generally using Code + Ionide, but in the case of this error I am simply running the FAKE script, i.e., .\build.cmd GenerateDocs. I have the latest version of VS 2017 installed (15.8.9) and a reboot did not help, unfortunately.

If this is just happening for me I won't worry about it too much - is anyone else able run that build step on this branch?

@samhanes
Copy link
Contributor Author

@smoothdeveloper Are you able to run the GenerateDocs target on this branch?

@smoothdeveloper smoothdeveloper self-assigned this Apr 10, 2019
@vasily-kirichenko vasily-kirichenko merged commit 37a6ae5 into fsprojects:master Jun 11, 2019
@vasily-kirichenko
Copy link
Contributor

Thanks! Published https://fsprojects.github.io/FSharp.Data.SqlClient/netcore.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoothdeveloper smoothdeveloper smoothdeveloper left review comments

Assignees

@smoothdeveloper smoothdeveloper

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samhanes @smoothdeveloper @vasily-kirichenko