-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StringReader provider #77
Add StringReader provider #77
Conversation
What about the review? |
@vasily-kirichenko Which review? thx |
@vasily-kirichenko Seems like you did not complete (publish) review. We see nothing |
match Path.IsPathRooted(path) with | ||
| false -> Path.Combine(resolutionFolder, path) | ||
| true -> path | ||
match File.Exists(filePath) with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use if..then..else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same control structure as in FileSystemProviver
.
For me a pattern match reads better, but sure it's a matter of taste.
Which style should I follow?
| false -> Path.Combine(resolutionFolder, path) | ||
| true -> path | ||
match File.Exists(filePath) with | ||
| false -> failwith (sprintf "Specified file [%s] could not be found" path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use failwithf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied over from FileSystemProvider
. Will change, as not error prone any more with the warning for extra arguments on falwithf
.
Damn. Github is too awesome for me :( |
Thanks for contribution! |
relates #71
without encoding support