Add StringReader provider #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the review? |
@vasily-kirichenko Which review? thx |
|
This one:
Can you see it, guys cannot you?.. |
|
@vasily-kirichenko Seems like you did not complete (publish) review. We see nothing |
| match Path.IsPathRooted(path) with | ||
| | false -> Path.Combine(resolutionFolder, path) | ||
| | true -> path | ||
| match File.Exists(filePath) with |
There was a problem hiding this comment.
Use if..then..else
There was a problem hiding this comment.
Same control structure as in FileSystemProviver.
For me a pattern match reads better, but sure it's a matter of taste.
Which style should I follow?
| | false -> Path.Combine(resolutionFolder, path) | ||
| | true -> path | ||
| match File.Exists(filePath) with | ||
| | false -> failwith (sprintf "Specified file [%s] could not be found" path) |
There was a problem hiding this comment.
Copied over from FileSystemProvider. Will change, as not error prone any more with the warning for extra arguments on falwithf.
|
Damn. Github is too awesome for me :( |
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #71
without encoding support