Allow not null implementation of IDisposable in CEs #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remove WIP commit. |
gdziadkiewicz
commented
Jul 9, 2020
gdziadkiewicz
force-pushed
the
feature/Allow_not_null_implementation_of_IDisposable_in_CEs
branch
2 times, most recently
from
95569f6
to
96bcd0f
Compare
gdziadkiewicz
force-pushed
the
feature/Allow_not_null_implementation_of_IDisposable_in_CEs
branch
from
96bcd0f
to
77a61c5
Compare
gdziadkiewicz
deleted the
feature/Allow_not_null_implementation_of_IDisposable_in_CEs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation backing
use!in most of the CEs for theIDisposableimplementing type to be null allowing. This is an artificial requirement which limits the usefulness of the code.This PR amends the implementations to allow type for which null is not a valid value.