Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report analyzer problem in GitHub #2962

Merged
merged 16 commits into from
Oct 17, 2023
Merged

Report analyzer problem in GitHub #2962

merged 16 commits into from
Oct 17, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 12, 2023

@nojaf
Copy link
Contributor Author

nojaf commented Oct 12, 2023

This is pretty cool I think:
image

@dawedawe
Copy link
Member

Awesome!

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@nojaf
Copy link
Contributor Author

nojaf commented Oct 16, 2023

Code scanning seems to work a little differently:

https://github.com/fsprojects/fantomas/security/code-scanning?query=pr%3A2962+tool%3AIonide.Analyzers.Cli+is%3Aopen

image

But I think the sarif will work out as expected.

@nojaf nojaf marked this pull request as ready for review October 16, 2023 14:30
@nojaf nojaf requested a review from dawedawe October 16, 2023 14:30
@nojaf nojaf mentioned this pull request Oct 16, 2023
Merged
dawedawe
dawedawe approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great integration. The sarif support is really a big step towards a professional product.

@nojaf nojaf merged commit 3026758 into fsprojects:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawedawe dawedawe dawedawe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @dawedawe