Make Fantomas compatible with FCS #3032
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, a quick update on the 'plain FCS vs. Fantomas.FCS fork' situation, as I promised @psfinaki. After some digging, it turns out we can work with plain FCS, but it's not all smooth sailing. Here's the deal:
FSharp.Core
8.0.100
. We're trying to support older versions, so that's a bit of a snag.Fantomas.Core
? Not so much. It could clash with other NuGet packages relying on FCS. Maybe we could use nightlies for the tool and keepFantomas.Core
on the stable releases, but is it worth the hassle?FCS
packages would be great for the compiler, acting as a solid regression test for the parser.dotnet/fsharp
and use it immediately. Switching toFCS
, even the nightly version, means we lose that quick turnaround. A prime example is the issue at Incorrect range for SynInterpolatedStringPart.String in extended interpolated string dotnet/fsharp#16418.So, where does that leave us? Honestly, it's a bit of a head-scratcher. This was part of a bigger exercise to understand why projects fork the F# compiler, but the answer isn't clear-cut. Thoughts?