Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1541: HTTPFilesystem has a race condition on data size between the open and read class, if content changes at server between the 2 class #1542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

masariello
Copy link

No description provided.

…etween the open and read class, if content changes at server between the 2 class
@martindurant
Copy link
Member

I'm pretty sure this will either convert regular HTTPFiles to HTTPStreamFiles (no random access) or fail on seek(.., 2). We should have explicit checks on those conditions to be sure.

@martindurant
Copy link
Member

Indeed, this breaks a bunch of tests, like:

>       if start >= self.size or start >= end:
E       TypeError: '>=' not supported between instances of 'int' and 'NoneType'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants