Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for windows #441

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Fix tests for windows #441

merged 3 commits into from
Oct 7, 2020

Conversation

DavidKatz-il
Copy link
Contributor

@DavidKatz-il DavidKatz-il commented Oct 7, 2020 •
edited by martindurant
Loading

Fixes #440

@DavidKatz-il DavidKatz-il mentioned this pull request Oct 7, 2020
Closed
@martindurant
Copy link
Member

Thanks. For the final one, it is only failing in the cleanup (which can be safely ignored). I would remove the finally block and stop using try: for the body of the test.

@martindurant
Copy link
Member

(happy to push the test here, if you don't have the time)

@martindurant
Copy link
Member

Unfortunately, just a touch of lint: please run black fsspec

@martindurant martindurant merged commit 449faf4 into fsspec:master Oct 7, 2020
@DavidKatz-il DavidKatz-il deleted the fix-tests-windows branch October 7, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failed on windows
2 participants
@DavidKatz-il @martindurant