spec: fix unstrip_protocol #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonburdo
force-pushed
the
fix/unstrip-protocol-orig-path
branch
from
d92b31c
to
acbaf6c
Compare
jonburdo
changed the title
The original `name` argument will be incorrectly returned in cases where it begins with one of the class's protocols.
jonburdo
force-pushed
the
fix/unstrip-protocol-orig-path
branch
from
acbaf6c
to
617f5ba
Compare
efiop
approved these changes
Jun 14, 2022
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979
Now the function only returns the original path if it starts with
f"{protocol}://"instead of just checking for"protocol".