-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rfc1918ClassBPrivateSpec incorrect matches #796
Fix Rfc1918ClassBPrivateSpec incorrect matches #796
Conversation
A test failed, but it does not seem related to my changes:
It already happened on master. |
I think the error that failed the build is:
Running |
…ts with characters in rfc allowed range but still outside of it
580c198
to
f863e6f
Compare
Didn't know about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Many thanks @jbenoit2011!
I can make a release with this fix soon. But before I do, it may be worth looking into another issue with
WDYT @jbenoit2011? |
I just pushed a patch to fix the start range of rfc1918 class b ips issue described in #702 |
Fix #795