Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Action status tracking #170

Merged
merged 11 commits into from
Nov 24, 2021

Conversation

dahlb
Copy link
Contributor

@dahlb dahlb commented Nov 23, 2021

No description provided.

@dahlb dahlb changed the title Action status tracking feat: Action status tracking Nov 23, 2021
@dahlb
Copy link
Contributor Author

dahlb commented Nov 23, 2021

this supersedes #153 and removes the sleeps from CA and USA which I've learned are considered bad form in async home assistant patterns because they hold onto a worker for the duration of the sleeping. @cdnninja when you have a chance can you see if this works for you, I made a bunch of assumptions about the CA status checking being the same as the USA status checking; open to other solutions and feedback just looking to reduce force updates which at least in USA aren't needed when you've waited for the action to complete and looking to remove the sleep calls

@dahlb dahlb self-assigned this Nov 23, 2021
@dahlb dahlb added Canada Canada Region enhancement New feature or request USA labels Nov 23, 2021
@cdnninja
Copy link
Collaborator

I will give this a test, hopefully tonight.

@cdnninja
Copy link
Collaborator

Works for lock unlock here. I haven't tried remote start but it is the same code.

@dahlb
Copy link
Contributor Author

dahlb commented Nov 24, 2021

@cdnninja did you notice with the lock/unlock if the HA status of the lock was updated after the action finished? besides just making sure the action code still works the other part is that it no longer uses force update at all after actions complete. This works in US and I'm guessing it will work as you status endpoints look very similar to the USA ones, but skipping force update is a big change that I want to make sure still updates after the lock/unlock :)

@cdnninja
Copy link
Collaborator

Yes it looks to update status correctly as well. I am happy to merge this if you are.

@dahlb dahlb merged commit 47ca3a1 into Hyundai-Kia-Connect:master Nov 24, 2021
@dahlb dahlb deleted the action_status_tracking branch November 24, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canada Canada Region enhancement New feature or request USA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants