Rework onKey event options #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clashsoft
reviewed
May 23, 2024
Comment on lines
465
to
468
| (event.isShiftDown() && (!annotation.strict() || annotation.shift())) && | ||
| (event.isControlDown() && (!annotation.strict() || annotation.control())) && | ||
| (event.isAltDown() && (!annotation.strict() || annotation.alt())) && | ||
| (event.isMetaDown() && (!annotation.strict() || annotation.meta())); |
There was a problem hiding this comment.
This boolean logic seems wrong, if the key is not down, the condition is never true
There was a problem hiding this comment.
Fixed in latest commit
Clashsoft
reviewed
May 23, 2024
ludo/src/main/java/de/uniks/ludo/controller/sub/CreditModalComponent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Kunz <[email protected]>
Clashsoft
reviewed
May 25, 2024
framework/src/main/java/org/fulib/fx/controller/internal/ReflectionSidecar.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
strictoption: Ifstrictis enabled, setting an option likeshifttofalsenow requires the key not to be pressed instead of simply being ignored.Additional information
I'm not sure if this is the best solution. While it keeps backwards compatibility and doesn't break any behavior, it has the downside of not covering all situations that would be possible with e.g. an enum.
With this implementation, either all or no settings are strict. This means it is not possible to require
shiftnot to be pressed whilst not caring ifaltis pressed or not.Addressing #101