Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new for loop constructor based on app #108

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add new for loop constructor based on app #108

merged 2 commits into from
Jun 10, 2024

Conversation

LeStegii
Copy link
Collaborator

Improvements/Deprecations

This PR adds a new constructor to the FxFor class, allowing to create an instance using a FulibFx instance instead of passing a ControllerManager directly.

  • Added new constructor taking FulibFxApp as an argument
  • Deprecated old constructor taking ControllerManager as an argument

@LeStegii LeStegii requested a review from Clashsoft June 10, 2024 09:21
@LeStegii LeStegii added enhancement New feature or request rework Refactoring or reworking parts of existing code labels Jun 10, 2024
@Clashsoft Clashsoft merged commit fbde2e2 into master Jun 10, 2024
5 checks passed
@Clashsoft Clashsoft deleted the refactor/for-constructor branch June 10, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clashsoft Clashsoft Awaiting requested review from Clashsoft

Assignees
No one assigned
Labels
enhancement New feature or request rework Refactoring or reworking parts of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeStegii @Clashsoft