Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight lost probes in sample history #1247

Closed
fujiapple852 opened this issue Jul 27, 2024 · 5 comments · Fixed by #1279
Closed

Highlight lost probes in sample history #1247

fujiapple852 opened this issue Jul 27, 2024 · 5 comments · Fixed by #1279
Labels
enhancement New feature or request tui
Milestone

Comments

@fujiapple852
Copy link
Owner

When a probe times out (does not respond before a round ends) or fails to send (due to a local network error) the samples chart shown it as the absence of a value (a blank vertical bar). For example:

Screenshot 2024-07-27 at 5 08 47 PM

It is desirable to show Awaited (i.e. timed out) and Failed probes as solid vertical lines of different colours to make the distinction clearer.

@fujiapple852 fujiapple852 added enhancement New feature or request tui labels Jul 27, 2024
@c-git
Copy link
Collaborator

c-git commented Jul 27, 2024

Yeah I think that would be more intuitive when reading the chart and would make nodes that never responded have a full bar instead of an empty bar which might be better. I think a full bar is better but I guess that's subjective.

@fujiapple852
Copy link
Owner Author

I actually did this in an early version of Trippy (red vertical bar for 0), but I had to vendor and modify tui-rs (as it was then) in place. I'll have to upstream the change to the widget.

@c-git
Copy link
Collaborator

c-git commented Jul 28, 2024

Is it possible to create a derived widget with the alternate behaviour? Or perhaps a toggle to choose the behaviour as I can imagine other cases where an empty space is the preferred behaviour.

@fujiapple852
Copy link
Owner Author

WIP:
Screenshot 2024-08-14 at 6 33 17 PM

@fujiapple852
Copy link
Owner Author

Feature request: ratatui/ratatui#1325
PR to implement it: ratatui/ratatui#1326

@fujiapple852 fujiapple852 changed the title Show error and timed out probes in samples chart Highlight lost probes in sample history Aug 18, 2024
fujiapple852 added a commit that referenced this issue Aug 18, 2024
fujiapple852 added a commit that referenced this issue Aug 18, 2024
@fujiapple852 fujiapple852 self-assigned this Aug 18, 2024
@fujiapple852 fujiapple852 added this to the 0.12.0 milestone Aug 18, 2024
fujiapple852 added a commit that referenced this issue Aug 18, 2024
fujiapple852 added a commit that referenced this issue Aug 18, 2024
fujiapple852 added a commit that referenced this issue Aug 18, 2024
@fujiapple852 fujiapple852 removed their assignment Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants