Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-by-one bug in max-rounds #906

Closed
fujiapple852 opened this issue Jan 4, 2024 · 0 comments · Fixed by #907
Closed

Off-by-one bug in max-rounds #906

fujiapple852 opened this issue Jan 4, 2024 · 0 comments · Fixed by #907
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

This bug causes the tracer to run for max_rounds + 1 rounds.

This bug is does not impact reports which terminate after the correct number of rounds and exit the process and thus stopping the tracer thread.

This bug is observed when using the tracer programatically and setting max_rounds.
@fujiapple852 fujiapple852 added the bug Something isn't working label Jan 4, 2024
@fujiapple852 fujiapple852 added this to the 0.10.0 milestone Jan 4, 2024
@fujiapple852 fujiapple852 self-assigned this Jan 4, 2024
fujiapple852 added a commit that referenced this issue Jan 4, 2024
@fujiapple852
fix(tracer): off-by-one bug in Tracer::finished (#906)
934d3c0 
This bug causes the tracer to run for `max_rounds + 1` rounds.  This bug is does
not impact reports which terminate after the correct number of rounds and exit
the process and thus stopping the `tracer` thread.  This bug is observed when
using the tracer programatically and setting `max_rounds`.
@fujiapple852 fujiapple852 mentioned this issue Jan 4, 2024
Merged
fujiapple852 added a commit that referenced this issue Jan 4, 2024
@fujiapple852
fix(tracer): off-by-one bug in Tracer::finished (#906)
ebac6c3 
This bug causes the tracer to run for `max_rounds + 1` rounds.  This bug is does
not impact reports which terminate after the correct number of rounds and exit
the process and thus stopping the `tracer` thread.  This bug is observed when
using the tracer programatically and setting `max_rounds`.
fujiapple852 added a commit that referenced this issue Jan 4, 2024
@fujiapple852
fix(tracer): off-by-one bug in Tracer::finished (#906)
1b98833 
This bug causes the tracer to run for `max_rounds + 1` rounds.  This bug is does
not impact reports which terminate after the correct number of rounds and exit
the process and thus stopping the `tracer` thread.  This bug is observed when
using the tracer programatically and setting `max_rounds`.
@fujiapple852 fujiapple852 removed their assignment Jan 8, 2024
@chenrui333 chenrui333 mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

fix(tracer): off-by-one bug in Tracer::finished (#906) fujiapple852/trippy
1 participant
@fujiapple852