Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't hard set play services version #134

Closed
Ehesp opened this issue Nov 15, 2016 · 5 comments
Closed

[Android] Don't hard set play services version #134

Ehesp opened this issue Nov 15, 2016 · 5 comments

Comments

@Ehesp
Copy link
Contributor

Ehesp commented Nov 15, 2016

Hello,

Bear in mind, I'm not to clued up to Android yet...

I keep running into the same issue whereby my build fails due to "Multiple dex files". The cause of this is conflicting play-services versions across multiple libs. This library hard sets the dep to 9.8.0.

Other libs seem to only set it to "whatever is latest", e.g: https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle#L44 & https://github.com/idehub/react-native-google-analytics-bridge/blob/master/android/build.gradle#L21

The only way I can fix these errors is by either:

  1. Adding this to my own build.gradle:
dependencies {
    compile ('com.google.android.gms:play-services-gcm:9.8.0') {
      force = true;
    }
    ...
  1. Going into node_modules, and changing the line to compile 'com.google.android.gms:play-services-base:+'.

Didn't want to make a PR since I'm not sure if this will have any repercussions?

@auser
Copy link
Contributor

auser commented Nov 15, 2016

That should be fine. Make a PR when you get a chance. I think that sounds like a great idea.

@Ehesp ^^

@auser
Copy link
Contributor

auser commented Nov 16, 2016

Actually, what do you think about doing this for all Firestack dependencies?

@Ehesp
Copy link
Contributor Author

Ehesp commented Nov 16, 2016

I supposed the only issue is if the lib isn't kept up to date with say the latest firebase SDK, then users are going to have weird issues.

@auser
Copy link
Contributor

auser commented Nov 17, 2016

Good point. I agree.

Ehesp added a commit to Ehesp/react-native-firestack that referenced this issue Nov 18, 2016
@Salakar
Copy link
Collaborator

Salakar commented Nov 19, 2016

Closing as fixed on v3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants