Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] – FirestackCloudMessaging.m: expected method body #188

Closed
tansart opened this issue Dec 11, 2016 · 5 comments
Closed

[v3] – FirestackCloudMessaging.m: expected method body #188

tansart opened this issue Dec 11, 2016 · 5 comments

Comments

@tansart
Copy link

tansart commented Dec 11, 2016

I get an error when I try to build an empty RN project using Firestack from the branch v3.

I get the following error:

/[...]/TestProject/node_modules/react-native-firestack/ios/Firestack/FirestackCloudMessaging.m:74:28: error: expected method body
- (void) requestPermissions(NSDictionary *)requestedPermissions

Current environment:
OS X 10.12.1
XCode 8.1 & 7.2.1
react-native-cli: 2.0.0
react-native: 0.39.1

Steps to reproduce:
react-native init TestProject
cd TestProject
The app compiles and runs properly at this stage.

npm i -S fullstackreact/react-native-firestack#v3
react-native link react-native-firestack
cd ios && pod update --verbose
cd .. && react-native run-ios

This is where I start getting the aforementioned error.
Same error when I try to run the project from TestProject.xcworkspace

Has anyone else encountered this issue?

@tansart
Copy link
Author

tansart commented Dec 17, 2016

For what it's worth, I'm not having the issue while using v3 on #167

@Salakar
Copy link
Collaborator

Salakar commented Dec 29, 2016

@chrisbianca is this something you could possibly look at? :)

@chrisbianca
Copy link
Contributor

@Salakar I've just tried this with the latest v3 and it compiles fine.

@stilva Can you confirm if this is still an issue?

@Salakar
Copy link
Collaborator

Salakar commented Dec 29, 2016

@chrisbianca @stilva sounds like an incorrectly setup project to me

Have made a note to review install docs sometime.

@tansart
Copy link
Author

tansart commented Dec 29, 2016

Can confirm this has been fixed. Thanks!

@tansart tansart closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants