Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM implementation #167

Open
wants to merge 37 commits into
base: v3
Choose a base branch
from
Open

FCM implementation #167

wants to merge 37 commits into from

Conversation

tretelny
Copy link

Most of the FCM implementation, local notifications could be cleaner/need to be tested more. Would be helpful to know how the JS methods want to call and define these things so can know how to better convert to native iOS components i.e. UILocalNotification etc

ghuh and others added 30 commits November 7, 2016 17:52
Parity of response format between ios and android
…ticateWithCredentialForProvider

Implement reauthenticateWithCredentialForProvider for Android
…rAuth

Fix Android listenForAuth method to correctly check for user
…tack

* 'master' of github.com:fullstackreact/react-native-firestack:
  Fix Android listenForAuth method to correctly check for user
Parity of response format between ios and android.
…ing_comma

Removing undefined's from filter arguments
forEach and map method on the DataSnapshot does not retain key
…alled.

- Fix weird error that NSError is not KVC compliant when storage is not configured
JS
- Fixed code seems to exist on several more locations but has not been fixed,
since there are no tests to ensure I don't break anything.
- Use storageUrl from default config if not set otherwise in JS
- Similar code exists on several other places that are not fixed since
no tests prevent breaking stuff.
Use storage url from .plist file if not setStorageUrl() hasn't been called
…tack

* 'master' of github.com:fullstackreact/react-native-firestack:
  Fix donwloadUrl to use storageUrl from .plist.
  Use storage url from .plist file if not setStorageUrl() hasn't been called.
  Fixed error calling length of undefined
  forEach and map method on the DataSnapshot does not retain key
  removing trailing comma
  Filter out undefined filters
  Parity of response format between ios and android. Added authenticated flag to response from getCurrentUser
auser and others added 7 commits November 18, 2016 12:58
 Database.js was factored out into the database/ folder.  This stuck
 around for some reason and the require('modules/database') preferred
 the old version
…dFile

Implement storage.download() for Android
Most of the FCM implementation, local notifications could be cleaner…
@auser
Copy link
Contributor

auser commented Nov 28, 2016

I'll check this out this evening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants