Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible Null Pointer Exception when logging an event on Android #147

Closed
wants to merge 1 commit into from

Conversation

chrisbianca
Copy link
Contributor

At the moment a NullPointerException is thrown when logging an event to Firebase Analytics that has no parameters.

Salakar added a commit to Salakar/react-native-firestack that referenced this pull request Nov 18, 2016
@Salakar
Copy link
Collaborator

Salakar commented Nov 18, 2016

Added to my branch, we'll be merging it this week/next week for the upcoming v3.

@chrisbianca
Copy link
Contributor Author

@Salakar Thanks.
I've just tried switching over to your new branch and spotted a couple of issues with iOS. What's the best way to let you know?

@Salakar
Copy link
Collaborator

Salakar commented Nov 18, 2016

I've not looked at ios yet, will get there - I'm most proficient in JS/Java so will need a hand ios side.

@auser @chrisbianca how about for my branch / v3 lets tag issues with [v3] in the title. So if you want to make an issue for my branch just start the name with [v3]. Would also welcome some help ios side if you'd like to contribute =]

@chrisbianca The point of my branch was to mirror the web api as close as possible and along the way I've added in new features and fixed a few bugs (android), it's almost exactly like the web api now, as you can see in my example on #140

I've redone auth to mirror web api (#118 - for example is all implemented) and added missing methods (android), implemented analytics (android only - ios needs doing) and a complete re-write of large portions of the JS api.

@chrisbianca
Copy link
Contributor Author

@Salakar Ah, that makes sense then!

Currently I have an iOS version of my app up and running, and just started testing the equivalent Android app. Ran into some issues with auth on Android, which highlighted that you'd fixed them in your branch.

I'm keen to get the Android app running, so will persist with your branch and start fixing the issues that I notice with the functionality I've implemented on iOS. I'll submit PRs as I go, if you're ok with that? It won't cover all of the functionality of RN-Firestack, as I haven't covered all of it, but will be a starting point.

@auser
Copy link
Contributor

auser commented Nov 18, 2016

I'll create the v3 branch and v3 issue tag a bit later today. Looking forward to digging into your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants