Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency with values emitted by firebase.auth.AuthProvider subclasses #226

Merged
merged 1 commit into from
Feb 5, 2017

Conversation

FrankSalad
Copy link

The objects emitted by the credential method of firebase.auth.TwitterAuthProvider, firebase.auth.FacebookAuthProvider, and firebase.auth.GoogleAuthProvider all have different shapes.

This lets me do

var firebasejs = require('firebase');
var credential = firebasejs.auth.FacebookAuthProvider.credential(accessToken);
var auth = firestack.auth().signInWithCredential(credential);

@auser auser merged commit 087c9ca into fullstackreact:v3 Feb 5, 2017
auser added a commit that referenced this pull request Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants